Add lightning-macros crate and drop bdk_macros dependency
#3330
+109
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
force-pushed
the
2024-09-add-macros-crate
branch
from
3eb61e1
to
eda480b
Compare
dunxen
previously approved these changes
Sep 22, 2024
4 tasks
TheBlueMatt
reviewed
Oct 1, 2024
|
Now pushed a fixup that removes the async trait functionality. While I think there is no real harm in having the original code around, happy to go this way, too. Let me know if I should squash or revert. |
|
Feel free to squash, then LGTM. |
tnull
force-pushed
the
2024-09-add-macros-crate
branch
from
9b066de
to
1dffe79
Compare
Squashed fixup without further changes. |
|
Oops, the |
TheBlueMatt
approved these changes
Oct 17, 2024
Previously, we used the `bdk_macros` dependency for some simple proc macros in `lightning-transaction-sync`. However, post-1.0 BDK doesn't further maintain this crate and will at some point probably yank it together with the old `bdk` crate that was split up. Here, we create a new crate for utility proc macros and ~~steal~~ add what we currently use (slightly modified for the latest `syn` version's API though). In the future we may want to expand this crate, e.g., for some `maybe_async` macros in the context of an `async KVStore` implementation.
tnull
force-pushed
the
2024-09-add-macros-crate
branch
from
1dffe79
to
99ae425
Compare
Grr🤦♂️ Fixed. |
TheBlueMatt
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
Gonna land this, only really removed code since @dunxen last looked and its pretty straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used the
bdk_macrosdependency for some simple proc macros inlightning-transaction-sync. However, post-1.0 BDK doesn't further maintain this crate and will at some point probably yank it together with the oldbdkcrate that was split up.Here, we create a new crate for utility proc macros and
stealadd what we currently use (slightly modified for the latestsynversion's API though). In the future we may want to expand this crate, e.g., for some further changes to themaybe_asyncmacros in the context of anasync KVStoreimplementation.